Skip to content

Consistent include pathing for new 2026 in theme-defaults#309880

Merged
aeschli merged 3 commits intomicrosoft:mainfrom
OscarPalafox:patch-1
Apr 16, 2026
Merged

Consistent include pathing for new 2026 in theme-defaults#309880
aeschli merged 3 commits intomicrosoft:mainfrom
OscarPalafox:patch-1

Conversation

@OscarPalafox
Copy link
Copy Markdown
Contributor

@OscarPalafox OscarPalafox commented Apr 14, 2026

The new themes use an absolute path instead of the relative one like other themes do (e.g. dark_modern.json). This PR addresses this.

Use relative path for includes
Use relative path for includes
@OscarPalafox
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@OscarPalafox OscarPalafox changed the title Consistent include pathing in theme-defaults Consistent include pathing in for new 2026 in theme-defaults Apr 14, 2026
@OscarPalafox
Copy link
Copy Markdown
Contributor Author

OscarPalafox commented Apr 15, 2026

Hey @aeschli @dmitrivMS! Thanks for approving, I'm afraid I don't have permissions to merge though. Can you guys please take care of it?

@OscarPalafox OscarPalafox changed the title Consistent include pathing in for new 2026 in theme-defaults Consistent include pathing for new 2026 in theme-defaults Apr 15, 2026
@aeschli aeschli merged commit 688c0b7 into microsoft:main Apr 16, 2026
26 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.117.0 milestone Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants