fix(chat): guard renderWelcomeViewContentIfNeeded against undisposed input part (#310356)#310822
Merged
roblourens merged 1 commit intomicrosoft:mainfrom Apr 16, 2026
Conversation
Yoyokrazy
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What — Add an early-return in
ChatWidget.renderWelcomeViewContentIfNeeded()when the input part has not been rendered (or was already disposed).Why — The method dereferences
this.input.currentModeKind, which hits a non-null assertion onthis.inputPartDisposable.value!. Invocations from the asyncshowModel→updateWidgetLockState→lockToCodingAgent/unlockFromCodingAgentchain could land while no input part was live, throwing unhandled errors (205 hits / 135 users reported in #310356).How — Early-return guard
if (!this.inputPartDisposable.value) { return; }at the top ofrenderWelcomeViewContentIfNeeded(). Mirrors the existing defensive pattern in the siblingrenderGettingStartedTipIfNeeded()(line ~1040) and the optional-chain at line 1026.Test plan — Manual repro via the agent-session flow that triggers
lockToCodingAgent/unlockFromCodingAgentbefore the input part renders; pre-fix this throws oninputPartDisposable.value!, post-fix it returns early. No unit test added (no existingchatWidget.test.tsharness).Fixes #310356